Yes, but the other actual run command is also different. I changed both. I don’t think chmod was the fix. Run it from the github.
I think the real issue is I was using single quotes around the command while I should have been using double quotes because for some reason that tends to work better with BigFix if the very outer quotes are double quotes, even though bash and sh don’t care themselves.
I removed the chmod line, still worked. It doesn’t hurt to keep it, but I also don’t think it does anything at all.
Also, if you need to dynamically look up /bin/sh instead of hard coding it, you can do something like this:
tuple string items 0 of concatenations ", " of ( it ; pathnames of files whose(name of it as lowercase = "sh" OR name of it as lowercase = "sh.exe") of (folders it) of unique values of (it as trimmed string) of substrings separated by (";";":") of values of (variables "PATH" of it; (if (windows of operating system) then (x64 variables "PATH" of it) else NOTHINGS) ) of environments ) of "/bin/sh"
This will take the first instance of sh found in the PATH, but will return /bin/sh if not found in PATH.
The Logpresso scan looks like it handles that part. I am strongly inclined to deprecate everything else we’ve written for this and use Logpresso for all the things.
(Which, I know, leaves a lot of OSes in the cold now, but I’m more inclined to get Logpresso working on those instead of trying to push further with shell scripts)
Is there a way to run the logpresso tool in --fix mode without having to tell it “y”?
When I’ve tested this on Linux and Windows and both systems require a user prompt when attempting to “–fix” the issues found. I’m reluctant to run it in an Action when it might sit there waiting for a use response that will never come.
